-
Notifications
You must be signed in to change notification settings - Fork 576
Expand file tree
/
Copy pathPrintfArrayParametersRule.php
More file actions
200 lines (167 loc) · 5.35 KB
/
Copy pathPrintfArrayParametersRule.php
File metadata and controls
200 lines (167 loc) · 5.35 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
<?php declare(strict_types = 1);
namespace PHPStan\Rules\Functions;
use PhpParser\Node;
use PhpParser\Node\Expr\FuncCall;
use PHPStan\Analyser\Scope;
use PHPStan\DependencyInjection\RegisteredRule;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\ShouldNotHappenException;
use PHPStan\Type\Constant\ConstantIntegerType;
use PHPStan\Type\IntegerRangeType;
use PHPStan\Type\IntegerType;
use PHPStan\Type\TypeCombinator;
use function count;
use function in_array;
use function max;
use function min;
use function sprintf;
/**
* @implements Rule<Node\Expr\FuncCall>
*/
#[RegisteredRule(level: 0)]
final class PrintfArrayParametersRule implements Rule
{
public function __construct(
private PrintfHelper $printfHelper,
private ReflectionProvider $reflectionProvider,
)
{
}
public function getNodeType(): string
{
return FuncCall::class;
}
public function processNode(Node $node, Scope $scope): array
{
if (!($node->name instanceof Node\Name)) {
return [];
}
if (!$this->reflectionProvider->hasFunction($node->name, $scope)) {
return [];
}
$functionReflection = $this->reflectionProvider->getFunction($node->name, $scope);
$name = $functionReflection->getName();
if (!in_array($name, ['vprintf', 'vsprintf'], true)) {
return [];
}
$args = $node->getArgs();
$argsCount = count($args);
if ($argsCount < 1) {
return []; // caught by CallToFunctionParametersRule
}
$formatArgType = $scope->getType($args[0]->value);
$placeHoldersCounts = [];
foreach ($formatArgType->getConstantStrings() as $formatString) {
$format = $formatString->getValue();
$count = $this->printfHelper->getPrintfPlaceholdersCount($format);
if ($count === null) {
return [
RuleErrorBuilder::message(sprintf(
'Call to %s contains an invalid placeholder.',
$name,
))->identifier(sprintf('argument.%s', $name))->build(),
];
}
$placeHoldersCounts[] = $count;
}
if ($placeHoldersCounts === []) {
return [];
}
$minCount = min($placeHoldersCounts);
$maxCount = max($placeHoldersCounts);
if ($minCount === $maxCount) {
$placeHoldersCount = new ConstantIntegerType($minCount);
} else {
$placeHoldersCount = IntegerRangeType::fromInterval($minCount, $maxCount);
if (!$placeHoldersCount instanceof IntegerRangeType && !$placeHoldersCount instanceof ConstantIntegerType) {
return [];
}
}
$formatArgsCounts = [];
if (isset($args[1])) {
$formatArgsType = $scope->getType($args[1]->value);
$constantArrays = $formatArgsType->getConstantArrays();
if ($constantArrays === []) {
$formatArgsCounts[] = new IntegerType();
}
foreach ($constantArrays as $constantArray) {
$formatArgsCounts[] = $constantArray->getArraySize();
}
}
if ($formatArgsCounts === []) {
$formatArgsCount = new ConstantIntegerType(0);
} else {
$formatArgsCount = TypeCombinator::union(...$formatArgsCounts);
if (!$formatArgsCount instanceof IntegerRangeType && !$formatArgsCount instanceof ConstantIntegerType) {
return [];
}
}
if (!$this->placeholdersMatchesArgsCount($placeHoldersCount, $formatArgsCount)) {
if ($placeHoldersCount instanceof IntegerRangeType) {
$placeholders = $this->getIntegerRangeAsString($placeHoldersCount);
$singlePlaceholder = false;
} else {
$placeholders = $placeHoldersCount->getValue();
$singlePlaceholder = $placeholders === 1;
}
if ($formatArgsCount instanceof IntegerRangeType) {
$values = $this->getIntegerRangeAsString($formatArgsCount);
$singleValue = false;
} else {
$values = $formatArgsCount->getValue();
$singleValue = $values === 1;
}
return [
RuleErrorBuilder::message(sprintf(
sprintf(
'%s, %s.',
$singlePlaceholder ? 'Call to %s contains %d placeholder' : 'Call to %s contains %s placeholders',
$singleValue ? '%d value given' : '%s values given',
),
$name,
$placeholders,
$values,
))->identifier(sprintf('argument.%s', $name))->build(),
];
}
return [];
}
private function placeholdersMatchesArgsCount(ConstantIntegerType|IntegerRangeType $placeHoldersCount, ConstantIntegerType|IntegerRangeType $formatArgsCount): bool
{
if ($placeHoldersCount instanceof ConstantIntegerType) {
if ($formatArgsCount instanceof ConstantIntegerType) {
return $placeHoldersCount->getValue() === $formatArgsCount->getValue();
}
// Zero placeholders + array
if ($placeHoldersCount->getValue() === 0) {
return true;
}
return false;
}
if (
$formatArgsCount instanceof IntegerRangeType
&& IntegerRangeType::fromInterval(1, null)->isSuperTypeOf($placeHoldersCount)->yes()
) {
if ($formatArgsCount->getMin() !== null && $formatArgsCount->getMax() !== null) {
// constant array
return $placeHoldersCount->isSuperTypeOf($formatArgsCount)->yes();
}
// general array
return IntegerRangeType::fromInterval(1, null)->isSuperTypeOf($formatArgsCount)->yes();
}
return false;
}
private function getIntegerRangeAsString(IntegerRangeType $range): string
{
if ($range->getMin() !== null && $range->getMax() !== null) {
return $range->getMin() . '-' . $range->getMax();
} elseif ($range->getMin() !== null) {
return $range->getMin() . ' or more';
} elseif ($range->getMax() !== null) {
return $range->getMax() . ' or less';
}
throw new ShouldNotHappenException();
}
}

