Update visibilty for descendants#7218
Merged
Merged
Conversation
escattone
approved these changes
Jan 29, 2026
|
|
||
| if "visible_to_groups" in form.base_fields: | ||
| if obj and not obj.is_root(): | ||
| parent = obj.get_parent() |
Contributor
There was a problem hiding this comment.
Since visibility and visible_to_groups are determined by the root, I'm thinking maybe for both we should, instead of the parent, use root = obj.get_root() and use the root's groups? Effectively it ends up the same, but just thinking it might be more consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.