Anonymous View
Skip to content

Translated HOC Page#286

Merged
hg-pyun merged 8 commits into
reactjs:masterfrom
dev-hikun:dev-hikun-patch-1
Feb 25, 2021
Merged

Translated HOC Page#286
hg-pyun merged 8 commits into
reactjs:masterfrom
dev-hikun:dev-hikun-patch-1

Conversation

@dev-hikun

@dev-hikun dev-hikun commented Feb 16, 2021

Copy link
Copy Markdown
Contributor

@netlify

netlify Bot commented Feb 16, 2021

Copy link
Copy Markdown

@netlify

netlify Bot commented Feb 16, 2021

Copy link
Copy Markdown

@taehwanno

Copy link
Copy Markdown
Contributor

리뷰는 미리 배정받으신 분의 의사를 먼저 확인한 뒤에 진행하도록 하겠습니다 ㅎㅎ

Ref: #1 (comment)

@taehwanno

Copy link
Copy Markdown
Contributor

#1 (comment) 미리 배정받으셨던 분이 허락해주셔서 리뷰 진행하도록 할게용
예전에 진행하다가 중단됐던 #187 도 연결시켜 둘게요 ㅎㅎ 몇 가지 리뷰 코멘트가 있으니 참고 부탁드리겠습니당

cc @junsikshim

@dev-hikun

dev-hikun commented Feb 17, 2021

Copy link
Copy Markdown
Contributor Author

@taehwanno @junsikshim 감사합니다!
저도 #187 보면서 진행했습니다

@junsikshim junsikshim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 작업했던 내용과 비교해서 커멘트를 남겼습니다~

Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
hg-pyun
hg-pyun previously approved these changes Feb 19, 2021

@hg-pyun hg-pyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun

hg-pyun commented Feb 19, 2021

Copy link
Copy Markdown
Member

@junsikshim 확인 한번 부탁드려요!

Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
Comment thread content/docs/higher-order-components.md Outdated
오탈자 수정 및 리뷰 적용
@dev-hikun

Copy link
Copy Markdown
Contributor Author

@junsikshim 좋은 리뷰들 감사합니다. 적용되었습니다.
@hg-pyun @taehwanno 확인 부탁드리겠습니다 :-)

@hg-pyun hg-pyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dev-hikun @junsikshim 두분 모두 고생하셨습니다!
LGTM

@hg-pyun hg-pyun merged commit b88c44e into reactjs:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants